Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 267593006: Fix missing dependencies in smoke/pubspec.yaml (Closed)

Created:
6 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix missing dependencies in smoke/pubspec.yaml R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/smoke/pubspec.yaml View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
I added the dependency when adding codegen/recorder, but it seems that I forgot to include ...
6 years, 7 months ago (2014-05-01 22:37:16 UTC) #1
Jennifer Messerly
lgtm
6 years, 7 months ago (2014-05-01 23:25:53 UTC) #2
Siggi Cherem (dart-lang)
6 years, 7 months ago (2014-05-01 23:28:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698