Issue 267443005: Add missing methods to JSNull.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267443005: Add missing methods to JSNull. (Closed)

Created:
6 years, 7 months ago by floitsch

Modified:
6 years, 7 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add missing methods to JSNull. Committed: https://code.google.com/p/dart/source/detail?r=35588

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/utils/recursive_import_test.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r35588 (presubmit successful).

6 years, 7 months ago (2014-04-30 18:48:07 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/267443005/diff/1/tests/utils/recursive_import_test.dart File tests/utils/recursive_import_test.dart (right): https://codereview.chromium.org/267443005/diff/1/tests/utils/recursive_import_test.dart#newcode64 tests/utils/recursive_import_test.dart:64: bool operator ==(other) => identical(null, other); `false` would ...

6 years, 7 months ago (2014-05-01 07:44:08 UTC) #3

floitsch

6 years, 7 months ago (2014-05-03 23:21:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/267443005/diff/1/tests/utils/recursive_import...
File tests/utils/recursive_import_test.dart (right):

https://codereview.chromium.org/267443005/diff/1/tests/utils/recursive_import...
tests/utils/recursive_import_test.dart:64: bool operator ==(other) =>
identical(null, other);
On 2014/05/01 07:44:08, karlklose wrote:
> `false` would have been sufficient.

Copy/paste from another JSNull implementation from somewhere else.

Expand Messages | Collapse Messages