Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 267393010: Don't use reuseAddress when testing, as we test for a specific origin. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use reuseAddress when testing, as we test for a specific origin. Also fixes a case on Linux where reuseAddress works bad with multicastLoopback. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -160 lines) Patch
M tests/standalone/io/raw_datagram_socket_test.dart View 3 chunks +172 lines, -160 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-08 08:46:19 UTC) #1
Søren Gjesse
LGTM!
6 years, 7 months ago (2014-05-08 09:08:02 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-08 09:17:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698