Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 267373002: Status file updates to make the tree green. (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Status file updates to make the tree green. Mark try/end_to_end_test as Fail, Timeout, updated issue 17935 Mark isolate/mandel_isolate_test Crash, Pass on simarm debug, filed issue 18670 Mark pkg/polymer/test/attr_mustache_test as CompileTimeError on dart2js on browsers (we skip this on command line vms already) - this happened after revision 35811 - filed issue 18667 Committed: https://code.google.com/p/dart/source/detail?r=35841

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/try/try.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 7 months ago (2014-05-07 06:22:23 UTC) #1
kasperl
https://codereview.chromium.org/267373002/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://codereview.chromium.org/267373002/diff/1/tests/isolate/isolate.status#newcode12 tests/isolate/isolate.status:12: Remove newline to keep things consistent. https://codereview.chromium.org/267373002/diff/1/tests/try/try.status File tests/try/try.status ...
6 years, 7 months ago (2014-05-07 06:24:10 UTC) #2
ricow1
6 years, 7 months ago (2014-05-07 06:27:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35841.

Powered by Google App Engine
This is Rietveld 408576698