Add "matchingTarget" function to Event, which is the Element that matched the CSS value selector.

Add "matchingTarget" function to Event, which is the Element that matched the CSS value selector.

Bug fix for https://code.google.com/p/dart/issues/detail?id=12931

BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28430

[blois, 2013-10-09 20:47:18]

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (left):

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:37: $CLASSNAME._private();
Why remove of this?

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:55: if
(target.matches('.selector')) {
hardcoded??

[Emily Fortuna, 2013-10-09 22:16:27]

try this again.

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (left):

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:37: $CLASSNAME._private();
On 2013/10/09 20:47:18, blois wrote:
> Why remove of this?

It got accidentally added in https://codereview.chromium.org/26279008/

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/3001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:55: if
(target.matches('.selector')) {
On 2013/10/09 20:47:18, blois wrote:
> hardcoded??

That's what I get for copying my comment from the bug discussion over here.
Fixed!

[blois, 2013-10-09 22:25:43]

https://codereview.chromium.org/26722002/diff/9001/tools/dom/src/EventStreamP...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/26722002/diff/9001/tools/dom/src/EventStreamP...
tools/dom/src/EventStreamProvider.dart:78: Stream<T> matches(String selector) =>
how about =>
this.where((event) => event.target.matchesWithAncestors(selector)).map((e) {
 e._selector = selector;
 return e;
});

Rather than adding the new class?

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:41: Element
_cachedMatchingTarget;
Probably does not need to be cached- in most cases it's only called once.

Plus adding fields to native types in JS need more annotations I think.

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:51: Element
matchingTarget() {
Can this be a getter?

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:58: if (_selector != null
&& target.matches(_selector)) {
Can there be an earlier out if _selector is null? Possibly even throw?

[Emily Fortuna, 2013-10-09 22:39:17]

ptal

https://codereview.chromium.org/26722002/diff/9001/tools/dom/src/EventStreamP...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/26722002/diff/9001/tools/dom/src/EventStreamP...
tools/dom/src/EventStreamProvider.dart:78: Stream<T> matches(String selector) =>
On 2013/10/09 22:25:44, blois wrote:
> how about =>
> this.where((event) => event.target.matchesWithAncestors(selector)).map((e) {
>  e._selector = selector;
>  return e;
> });
> 
> Rather than adding the new class?
Good point. fixed.

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:41: Element
_cachedMatchingTarget;
On 2013/10/09 22:25:44, blois wrote:
> Probably does not need to be cached- in most cases it's only called once.
> 
> Plus adding fields to native types in JS need more annotations I think.

Removed

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:51: Element
matchingTarget() {
On 2013/10/09 22:25:44, blois wrote:
> Can this be a getter?

Yeah, but it felt like a function was a little more appropriate since it does a
chunk of calculation beforehand. If you prefer I can switch it though.

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:58: if (_selector != null
&& target.matches(_selector)) {
On 2013/10/09 22:25:44, blois wrote:
> Can there be an earlier out if _selector is null? Possibly even throw?

added earlier out.

[blois, 2013-10-09 23:12:57]

lgtm

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/9001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Event.darttemplate:51: Element
matchingTarget() {
On 2013/10/09 22:39:18, Emily Fortuna wrote:
> On 2013/10/09 22:25:44, blois wrote:
> > Can this be a getter?
> 
> Yeah, but it felt like a function was a little more appropriate since it does
a
> chunk of calculation beforehand. If you prefer I can switch it though.

Yes plz! It just feels odd as a method when it's beside target and
currentTarget.

https://codereview.chromium.org/26722002/diff/20001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_Event.darttemplate (right):

https://codereview.chromium.org/26722002/diff/20001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_Event.darttemplate:43: * then this value will
be null.
Update comment for exception

[Emily Fortuna, 2013-10-09 23:43:25]

Committed patchset #4 manually as r28430 (presubmit successful).