Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 267153002: Support general handling of type variables by substituting types into the current context. (Closed)

Created:
6 years, 7 months ago by Johnni Winther
Modified:
6 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support general handling of type variables by substituting types into the current context. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=35888

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Rebased + reinserted unalias #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -71 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 3 chunks +39 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/helpers/trace.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ordered_typeset.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 22 chunks +67 lines, -44 lines 0 comments Download
A tests/language/generic_field_mixin2_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/language/generic_field_mixin3_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/language/generic_field_mixin4_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A tests/language/generic_field_mixin5_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A + tests/language/generic_field_mixin6_test.dart View 2 chunks +19 lines, -12 lines 0 comments Download
A tests/language/generic_field_mixin_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
6 years, 7 months ago (2014-05-06 11:54:07 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/267153002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/267153002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode927 sdk/lib/_internal/compiler/implementation/elements/elements.dart:927: /// A list of all Comment is incomplete. ...
6 years, 7 months ago (2014-05-07 12:46:37 UTC) #2
Johnni Winther
https://codereview.chromium.org/267153002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/267153002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode927 sdk/lib/_internal/compiler/implementation/elements/elements.dart:927: /// A list of all On 2014/05/07 12:46:37, karlklose ...
6 years, 7 months ago (2014-05-08 07:03:59 UTC) #3
Johnni Winther
6 years, 7 months ago (2014-05-08 08:11:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698