Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2671243002: Fix bug in readAsString when charset is LATIN-1 and content-length is set. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/io_io.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/loader_http_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-06 09:32:25 UTC) #2
floitsch
LGTM although I'm not sure the capacity is kept when decreasing the length.
3 years, 10 months ago (2017-02-06 09:59:22 UTC) #3
Lasse Reichstein Nielsen
On 2017/02/06 09:59:22, floitsch wrote: > LGTM although I'm not sure the capacity is kept ...
3 years, 10 months ago (2017-02-06 10:10:10 UTC) #4
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-06 10:11:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b1ee7b6abf6ce80877421067360ce7ed64eccb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698