Final variables induce a setter that throws NSME

Final variables induce a setter that throws NSME

Clean up handling of const and final variables. They induce a
setter that throws a NSME, rather than a compile-time error.

Delay the AST conversion of loading a const field into loading
the literal value. The conversion is now done when we know
that the load in on the right hand side of an expression.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28408

[srdjan, 2013-10-09 17:07:39]

lgtm

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:3369: // Static const and static final fields must have an
initializer.
Please add comment that static const fields are implicitly final.

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:4713: if (!is_getter &&
library_.LookupLocalField(*field_name) != Object::null()) {
Add parentheses

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:7819: static AstNode* LoadIfStaticConst(AstNode* expr) {
IMO, name is not quite clear (there is no load involved if static const). Maybe:
LiteralIfStaticConst?

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:8154: // No function to closureize found found.
s/closureize/closurize/

[hausner, 2013-10-09 17:15:19]

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:3369: // Static const and static final fields must have an
initializer.
On 2013/10/09 17:07:39, srdjan wrote:
> Please add comment that static const fields are implicitly final.

Done.

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:4713: if (!is_getter &&
library_.LookupLocalField(*field_name) != Object::null()) {
On 2013/10/09 17:07:39, srdjan wrote:
> Add parentheses

Done.

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:7819: static AstNode* LoadIfStaticConst(AstNode* expr) {
On 2013/10/09 17:07:39, srdjan wrote:
> IMO, name is not quite clear (there is no load involved if static const).
Maybe:
> LiteralIfStaticConst?

Done.

https://codereview.chromium.org/26703002/diff/6001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:8154: // No function to closureize found found.
On 2013/10/09 17:07:39, srdjan wrote:
> s/closureize/closurize/

Done.

[hausner, 2013-10-09 17:33:15]

Committed patchset #4 manually as r28408.