Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 266923009: Improve doc for ClosureMirror.function. (Closed)

Created:
6 years, 7 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve doc for ClosureMirror.function. R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=40160

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M sdk/lib/mirrors/mirrors.dart View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
https://codereview.chromium.org/266923009/diff/20001/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/266923009/diff/20001/sdk/lib/mirrors/mirrors.dart#newcode510 sdk/lib/mirrors/mirrors.dart:510: MethodMirror get function; Actually, the accessors on FunctionTypeMirror would ...
6 years, 7 months ago (2014-05-06 20:12:21 UTC) #1
rmacnak
6 years, 3 months ago (2014-09-11 00:37:32 UTC) #2
gbracha
https://chromiumcodereview.appspot.com/266923009/diff/20001/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://chromiumcodereview.appspot.com/266923009/diff/20001/sdk/lib/mirrors/mirrors.dart#newcode510 sdk/lib/mirrors/mirrors.dart:510: MethodMirror get function; On 2014/05/06 20:12:21, rmacnak wrote: > ...
6 years, 3 months ago (2014-09-11 00:49:33 UTC) #3
rmacnak
6 years, 3 months ago (2014-09-11 01:42:02 UTC) #4
gbracha
lgtm
6 years, 3 months ago (2014-09-11 15:07:27 UTC) #5
rmacnak
6 years, 3 months ago (2014-09-11 16:48:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698