Issue 26686005: Revert 28422

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26686005: Revert 28422 (Closed)

Created:
7 years, 2 months ago by Cutch

Modified:
7 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert 28422 BUG= Committed: https://code.google.com/p/dart/source/detail?r=28426

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1301 lines)			Patch
M	runtime/bin/bin.gypi	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/bin/main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/resources_sources.gypi	View	2 chunks	+0 lines, -257 lines	0 comments	Download
D	runtime/bin/vmservice/client/.gitignore	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	runtime/bin/vmservice/client/index.html	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	runtime/bin/vmservice/client/index.html_bootstrap.dart	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/observatory.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/observatory_elements.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/observatory_elements.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory/application.dart	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory/isolate_manager.dart	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory/location_manager.dart	View	1 chunk	+0 lines, -123 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory/request_manager.dart	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.dart	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.html	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.html	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.html	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.html	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.dart	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.html	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.dart	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.html	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/navigation_bar.html	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.dart	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.dart	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/response_viewer.html	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.html	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	runtime/bin/vmservice/gen_resources_sources.sh	View	1 chunk	+0 lines, -49 lines	0 comments	Download
M	runtime/bin/vmservice/resources.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/server.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/tools/create_resources.py	View	6 chunks	+5 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r28426 (presubmit successful).

7 years, 2 months ago (2013-10-09 22:24:35 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages