Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 26685004: Expand usage of defaultEncoding in HttpBody in the http_server package. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Expand usage of defaultEncoding in HttpBody in the http_server package. This fixes a few cases where other default encodings was used. Given that we operate with the concept of a default encoding, to use that encoding makes more sense. BUG=https://code.google.com/p/dart/issues/detail?id=13928 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28453

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add link and generate docs for http_server. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M pkg/http_server/lib/src/http_body_impl.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/http_server/lib/src/http_multipart_form_data.dart View 1 1 chunk +9 lines, -2 lines 0 comments Download
M pkg/http_server/lib/src/http_multipart_form_data_impl.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/http_server/test/http_multipart_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M utils/apidoc/apidoc.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-10-10 12:32:12 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/26685004/diff/1/pkg/http_server/lib/src/http_multipart_form_data.dart File pkg/http_server/lib/src/http_multipart_form_data.dart (right): https://codereview.chromium.org/26685004/diff/1/pkg/http_server/lib/src/http_multipart_form_data.dart#newcode72 pkg/http_server/lib/src/http_multipart_form_data.dart:72: * header is missing, the data is decoded ...
7 years, 2 months ago (2013-10-10 12:37:05 UTC) #2
Anders Johnsen
PTAL, added generation of http_server docs. https://codereview.chromium.org/26685004/diff/1/pkg/http_server/lib/src/http_multipart_form_data.dart File pkg/http_server/lib/src/http_multipart_form_data.dart (right): https://codereview.chromium.org/26685004/diff/1/pkg/http_server/lib/src/http_multipart_form_data.dart#newcode72 pkg/http_server/lib/src/http_multipart_form_data.dart:72: * header is ...
7 years, 2 months ago (2013-10-10 13:24:15 UTC) #3
Søren Gjesse
lgtm
7 years, 2 months ago (2013-10-10 14:04:43 UTC) #4
Anders Johnsen
7 years, 2 months ago (2013-10-10 14:09:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r28453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698