Cache number of type arguments in class object instead of recalculating it.

Cache number of type arguments in class object instead of recalculating it.
Reduce size of num_native_fields field in class object.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28670

[siva, 2013-10-15 00:06:57]

lgtm

https://codereview.chromium.org/26682003/diff/8001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/26682003/diff/8001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:1922: bool Class::HasTypeArguments() const {
Is this HasTypeArguments optimization necessary anymore. Since we will be paying
the cost of NumTypeArguments only once it maybe equally efficient to check 'if
(NumTypeArguments() > 0)' where ever we are doing 'if HasTypeArguments()'

[regis, 2013-10-15 17:49:14]

Removing HasTypeArguments() unveiled issues with the initialization of the
fields caching the number of type arguments for vm classes. I am sorting this
out now...

https://codereview.chromium.org/26682003/diff/8001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/26682003/diff/8001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:1922: bool Class::HasTypeArguments() const {
On 2013/10/15 00:06:57, siva wrote:
> Is this HasTypeArguments optimization necessary anymore. Since we will be
paying
> the cost of NumTypeArguments only once it maybe equally efficient to check 'if
> (NumTypeArguments() > 0)' where ever we are doing 'if HasTypeArguments()'

You are right. This is now overkill. I have removed this function and updated
(lots) of sources.

[siva, 2013-10-15 18:25:42]

still LGTM

[regis, 2013-10-15 18:31:44]

Committed patchset #5 manually as r28670 (presubmit successful).