Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 26682002: Add test for new final-field implicit setter semantics. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, ngeoffray, iposva, Brian Wilkerson
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Mark static warning as such. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
A tests/language/implicit_setter_test.dart View 1 1 chunk +63 lines, -0 lines 2 comments Download
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-09 10:59:53 UTC) #1
Lasse Reichstein Nielsen
https://codereview.chromium.org/26682002/diff/1/tests/language/implicit_setter_test.dart File tests/language/implicit_setter_test.dart (right): https://codereview.chromium.org/26682002/diff/1/tests/language/implicit_setter_test.dart#newcode20 tests/language/implicit_setter_test.dart:20: void set cx(value) { x = value; } // ...
7 years, 2 months ago (2013-10-09 11:08:39 UTC) #2
Johnni Winther
lgtm
7 years, 2 months ago (2013-10-09 11:19:15 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 manually as r28400 (presubmit successful).
7 years, 2 months ago (2013-10-09 11:27:37 UTC) #4
ngeoffray
7 years, 2 months ago (2013-10-17 09:15:23 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/26682002/diff/4001/tests/language/implicit_se...
File tests/language/implicit_setter_test.dart (right):

https://codereview.chromium.org/26682002/diff/4001/tests/language/implicit_se...
tests/language/implicit_setter_test.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
2012 -> 2013

https://codereview.chromium.org/26682002/diff/4001/tests/language/implicit_se...
tests/language/implicit_setter_test.dart:22: erase(this).x = value;  // but
crash even if the direct setting is omitted.
Why isn't this a /// 03: runtime error?

Powered by Google App Engine
This is Rietveld 408576698