Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 266783002: Save the entry context for a function that has captured loop variables. (Closed)

Created:
6 years, 7 months ago by turnidge
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Save the entry context for a function that has captured loop variables. BUG=18561 R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=35692

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : flow graph builder #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -23 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 2 4 3 chunks +11 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +15 lines, -7 lines 0 comments Download
M runtime/vm/parser_test.cc View 1 2 3 4 2 chunks +62 lines, -10 lines 0 comments Download
M runtime/vm/scopes.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/scopes.cc View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
6 years, 7 months ago (2014-05-01 20:23:40 UTC) #1
turnidge
6 years, 7 months ago (2014-05-01 21:51:04 UTC) #2
Vyacheslav Egorov (Google)
lgtm
6 years, 7 months ago (2014-05-01 22:17:10 UTC) #3
turnidge
6 years, 7 months ago (2014-05-02 16:14:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r35692 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698