Further code review changes for WebSocket.fromUpgradedSocket.

Further code review changes for WebSocket.fromUpgradedSocket.

BUG=18172
R=ajohnsen@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35764

[Anders Johnsen, 2014-05-01 05:53:04]

LGTM, with comment.

https://codereview.chromium.org/266653002/diff/1/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/266653002/diff/1/sdk/lib/io/websocket.dart#ne...
sdk/lib/io/websocket.dart:153: if (serverSide == null) {
This is very controversial, but I believe it's the best we can do. Let's get
this in, and we can iterate it a bit (always easier to relax then restrict).

https://codereview.chromium.org/266653002/diff/1/tests/standalone/io/web_sock...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/266653002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:389: testFromUpgradedSocket() {
It would be nice if you added a asyncStart/asyncEnd, to ensure it actually
executes the code we expect.

[kustermann, 2014-05-01 08:14:17]

lgtm

Though as Anders says, this is controversial:
Having required named parameters is non-standard dart convention and people will
not expect that.

I usually prefer if people document it on the using side of the interfaces, now
we force them to do it.

[nweiz, 2014-05-01 18:13:14]

https://codereview.chromium.org/266653002/diff/1/tests/standalone/io/web_sock...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/266653002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:389: testFromUpgradedSocket() {
On 2014/05/01 05:53:04, Anders Johnsen wrote:
> It would be nice if you added a asyncStart/asyncEnd, to ensure it actually
> executes the code we expect.

Done.

[nweiz, 2014-05-05 20:28:08]

Committed patchset #2 manually as r35764 (presubmit successful).