Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26662006: Changed LinkedHashSet to Set and LinkedHashMap to Map. (Closed)

Created:
7 years, 2 months ago by kasperl
Modified:
7 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed LinkedHashSet to Set and LinkedHashMap to Map. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=28636

Patch Set 1 #

Patch Set 2 : HashMap -> Map. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -59 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 9 chunks +12 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/keyword.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/expensive_map.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/expensive_set.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
This is first step towards experimenting with custom sets and maps in our implementation.
7 years, 2 months ago (2013-10-15 11:50:08 UTC) #1
ahe
lgtm
7 years, 2 months ago (2013-10-15 11:56:27 UTC) #2
kasperl
7 years, 2 months ago (2013-10-15 12:02:21 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r28636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698