Address a number of open issues.

Address a number of open issues.

Fix example in README.md (#20) Add missing import in io_io.dart (#18);

Add error message when trying to load resource that cannot be resolved (#17),
instead of just failing when trying to use a `null` URI.

Make HttpClient be shared and reduce max number of connections to same server.
Hopefully this addresses #19. If not, the program really needs more
file descriptors than the OS provides.

R=floitsch@google.com

Committed: https://github.com/dart-lang/resource/commit/15728b5ef6b978848e211a90b9db54c8aa67cc34

[Lasse Reichstein Nielsen, 2017-02-01 10:17:06]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-02-01 12:18:00]

LGTM.

https://codereview.chromium.org/2666013004/diff/40001/lib/src/resolve.dart
File lib/src/resolve.dart (right):

https://codereview.chromium.org/2666013004/diff/40001/lib/src/resolve.dart#ne...
lib/src/resolve.dart:12: resolvedUri ?? new ArgumentError.value(uri, "uri",
"Unknown package"));
That looks wrong.
I'm guessing you wanted to throw the argument error.
I prefer not to use ?? for that.

[Lasse Reichstein Nielsen, 2017-02-01 12:44:37]

https://codereview.chromium.org/2666013004/diff/40001/lib/src/resolve.dart
File lib/src/resolve.dart (right):

https://codereview.chromium.org/2666013004/diff/40001/lib/src/resolve.dart#ne...
lib/src/resolve.dart:12: resolvedUri ?? new ArgumentError.value(uri, "uri",
"Unknown package"));
True, should have had a throw.
Rewriting to the full if-statement.

[Lasse Reichstein Nielsen, 2017-02-01 12:46:50]

Description was changed from

==========
Address a number of open issues.

Fix example in README.md (#20) Add missing import in io_io.dart (#18);

Add error message when trying to load resource that cannot be resolved (#17),
instead of just failing when trying to use a `null` URI.

Make HttpClient be shared and reduce max number of connections to same server.
Hopefully this addresses #19. If not, the program really needs more
file descriptors than the OS provides.
==========

to

==========
Address a number of open issues.

Fix example in README.md (#20) Add missing import in io_io.dart (#18);

Add error message when trying to load resource that cannot be resolved (#17),
instead of just failing when trying to use a `null` URI.

Make HttpClient be shared and reduce max number of connections to same server.
Hopefully this addresses #19. If not, the program really needs more
file descriptors than the OS provides.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/resource/commit/15728b5ef6b978848e211a90b9db54c8...
==========

[Lasse Reichstein Nielsen, 2017-02-01 12:46:52]

Committed patchset #5 (id:80001) manually as
15728b5ef6b978848e211a90b9db54c8aa67cc34 (presubmit successful).