Issue 26660004: Updating todomvc for some polymer changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26660004: Updating todomvc for some polymer changes (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating todomvc for some polymer changes Should have caught some earlier, but I just added the base class validation. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=28624

Patch Set 1 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	pkg/polymer/lib/src/instance.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/polymer/test/take_attributes_test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	samples/third_party/todomvc/web/router_options.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/third_party/todomvc/web/todo_row.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/26660004/diff/4001/pkg/polymer/test/take_attributes_test.dart File pkg/polymer/test/take_attributes_test.dart (right): https://codereview.chromium.org/26660004/diff/4001/pkg/polymer/test/take_attributes_test.dart#newcode97 pkg/polymer/test/take_attributes_test.dart:97: //expect(queryXTag("#zot0").number, 84); I had switched this over so we'd ...

7 years, 2 months ago (2013-10-15 00:52:22 UTC) #1

blois

Committed patchset #1 manually as r28624 (presubmit successful).

7 years, 2 months ago (2013-10-15 00:52:24 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages