Issue 26654006: Emits additional output when test_runner_test fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26654006: Emits additional output when test_runner_test fails. (Closed)

Created:
7 years, 2 months ago by zra

Modified:
7 years, 2 months ago

Reviewers:
regis, floitsch, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Emits additional output when test_runner_test fails. On SIMARM and SIMMIPS, test_runner_test is flaky. Further, we have been unable to reproduce the failure case locally. The test fails when the "Unexpected fail" exception is thrown in processCompletedTest. This change prints the stdout and stderr of the completed test. With this output in the flakylogs, we'll hopefully be able to diagnose the problem. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28420

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	tests/standalone/io/test_runner_test.dart	View		1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

7 years, 2 months ago (2013-10-09 21:26:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r28420 (presubmit successful).

Expand Messages | Collapse Messages