Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 266323002: Class view: Retained size of all instances. (Closed)

Created:
6 years, 7 months ago by koda
Modified:
6 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Class view: Retained size of all instances. Uses eval-link to compute retained size on request. Does not round to MB or other human-friendly units. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35773

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -508 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 161 chunks +257 lines, -254 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 161 chunks +257 lines, -254 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/service_test.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 7 months ago (2014-05-05 21:03:03 UTC) #1
Cutch
lgtm https://codereview.chromium.org/266323002/diff/20001/runtime/bin/vmservice/client/lib/src/elements/class_view.dart File runtime/bin/vmservice/client/lib/src/elements/class_view.dart (right): https://codereview.chromium.org/266323002/diff/20001/runtime/bin/vmservice/client/lib/src/elements/class_view.dart#newcode22 runtime/bin/vmservice/client/lib/src/elements/class_view.dart:22: // TODO(koda): Add no-arg "calculate-link" instead of reusing ...
6 years, 7 months ago (2014-05-05 21:07:58 UTC) #2
koda
6 years, 7 months ago (2014-05-05 22:10:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r35773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698