Clean patch implementation.

Clean patch implementation.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35799

[karlklose, 2014-05-06 09:27:07]

LGTM!

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:732: extends
ElementX
Does the 'extends ... with' clause fit in one line? I would prefer to format it
that way.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1233: with
PatchMixin<ParameterElement>
Ditto.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1431: extends
ElementX
Ditto.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2539: var/*E*/
patch = null;
Use the bound (Element) instead of var.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2548: /*E*/ get
implementation => isPatched ? patch : this;
Use Element.

[Johnni Winther, 2014-05-06 12:05:29]

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:732: extends
ElementX
On 2014/05/06 09:27:07, karlklose wrote:
> Does the 'extends ... with' clause fit in one line? I would prefer to format
it
> that way.

Done.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1233: with
PatchMixin<ParameterElement>
On 2014/05/06 09:27:07, karlklose wrote:
> Ditto.

Done.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1431: extends
ElementX
On 2014/05/06 09:27:07, karlklose wrote:
> Ditto.

Done.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2539: var/*E*/
patch = null;
On 2014/05/06 09:27:07, karlklose wrote:
> Use the bound (Element) instead of var.

Done. Added temporary explicit getters to BaseClassElementX and LibraryElementX
to preserve the current typing.

https://codereview.chromium.org/266193004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:2548: /*E*/ get
implementation => isPatched ? patch : this;
On 2014/05/06 09:27:07, karlklose wrote:
> Use Element.

Done.

[Johnni Winther, 2014-05-06 12:25:03]

Committed patchset #2 manually as r35799 (presubmit successful).