Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 26607003: Change promote script to be able to archive to the new gs://dart-archive/ location (Closed)

Created:
7 years, 2 months ago by kustermann
Modified:
7 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change promote script to be able to archive to the new gs://dart-archive/ location R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=28631

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -6 lines) Patch
M editor/build/promote.py View 1 2 6 chunks +66 lines, -5 lines 0 comments Download
M tools/bots/bot_utils.py View 1 2 3 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 2 months ago (2013-10-14 13:45:17 UTC) #1
ricow1
Code lgtm, but please add a comment about the structure https://codereview.chromium.org/26607003/diff/7001/editor/build/promote.py File editor/build/promote.py (right): https://codereview.chromium.org/26607003/diff/7001/editor/build/promote.py#newcode284 ...
7 years, 2 months ago (2013-10-14 15:39:38 UTC) #2
kustermann
https://codereview.chromium.org/26607003/diff/7001/editor/build/promote.py File editor/build/promote.py (right): https://codereview.chromium.org/26607003/diff/7001/editor/build/promote.py#newcode284 editor/build/promote.py:284: def _PromoteDartArchiveBuild(channel, revision): On 2013/10/14 15:39:38, ricow1 wrote: > ...
7 years, 2 months ago (2013-10-15 08:01:17 UTC) #3
kustermann
7 years, 2 months ago (2013-10-15 08:10:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r28631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698