Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266043004: Small cleanup to Code and Profiler pages (Closed)

Created:
6 years, 7 months ago by Cutch
Modified:
6 years, 7 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Small cleanup to Code and Profiler - Profiler doesn't show expander when node has no children. - Code name is not prefixed with * on VM side. - <code-ref> prefixes code name with * if referenced code is optimized. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35807

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -70 lines) Patch
A runtime/bin/vmservice/client/build.sh View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 chunks +21 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 25 chunks +32 lines, -22 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 chunks +21 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 25 chunks +32 lines, -22 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_ref.html View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_view.html View 1 2 1 chunk +14 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_profile.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/view_model.dart View 2 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_ref.html View 1 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_view.html View 1 1 chunk +14 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
6 years, 7 months ago (2014-05-06 15:58:54 UTC) #1
turnidge
lgtm, minor comments. https://codereview.chromium.org/266043004/diff/1/runtime/bin/vmservice/client/lib/src/elements/code_ref.html File runtime/bin/vmservice/client/lib/src/elements/code_ref.html (right): https://codereview.chromium.org/266043004/diff/1/runtime/bin/vmservice/client/lib/src/elements/code_ref.html#newcode14 runtime/bin/vmservice/client/lib/src/elements/code_ref.html:14: <a href="{{ url }}"><span>*</span><span>{{ name }}</span></a> ...
6 years, 7 months ago (2014-05-06 16:05:41 UTC) #2
Cutch
https://codereview.chromium.org/266043004/diff/1/runtime/bin/vmservice/client/lib/src/elements/code_ref.html File runtime/bin/vmservice/client/lib/src/elements/code_ref.html (right): https://codereview.chromium.org/266043004/diff/1/runtime/bin/vmservice/client/lib/src/elements/code_ref.html#newcode14 runtime/bin/vmservice/client/lib/src/elements/code_ref.html:14: <a href="{{ url }}"><span>*</span><span>{{ name }}</span></a> On 2014/05/06 16:05:41, ...
6 years, 7 months ago (2014-05-06 16:29:03 UTC) #3
Cutch
6 years, 7 months ago (2014-05-06 16:37:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r35807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698