Change generic comment syntax to real generic syntax.

Change generic comment syntax to real generic syntax.

R=nweiz@google.com

Committed: https://github.com/dart-lang/async/commit/7a833401c86e20dd82cfd34e8b9e010425ff8216

[Lasse Reichstein Nielsen, 2017-01-31 12:11:15]

lrn@google.com changed reviewers:
+ nweiz@google.com

[Lasse Reichstein Nielsen, 2017-01-31 12:11:16]

If I'm changing dependency to 1.21 anyway for the byte-collector code, I might
as well go all the way.

[nweiz, 2017-01-31 22:28:58]

It looks like there are a lot of formatting changes here that make the code
harder to read.

https://codereview.chromium.org/2660333005/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2660333005/diff/1/CHANGELOG.md#newcode5
CHANGELOG.md:5: * Switched to using generic method syntax.
I don't think we need to document this. The SDK constraint will automatically
exclude SDK versions that don't support generic method syntax, and on newer SDKs
the difference is transparent.

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dart
File lib/src/delegate/future.dart (right):

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dar...
lib/src/delegate/future.dart:31: Future<S> then<S>(dynamic onValue(T value),
{Function onError}) => _future
Putting [_future] way out on the right seems less readable to me.

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/stream_con...
File lib/src/delegate/stream_consumer.dart (right):

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/stream_con...
lib/src/delegate/stream_consumer.dart:26: is StreamConsumer<T>
Same here—I think the originally formatting is a lot easier to understand.

https://codereview.chromium.org/2660333005/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2660333005/diff/1/pubspec.yaml#newcode13
pubspec.yaml:13: sdk: "^1.21.0"
You can't use "^" in SDK constraints, since older pub versions don't understand
them and they rely on the SDK constraint to filter out packages that use
unsupported features (like "^").

[Lasse Reichstein Nielsen, 2017-02-01 06:51:38]

https://codereview.chromium.org/2660333005/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2660333005/diff/1/CHANGELOG.md#newcode5
CHANGELOG.md:5: * Switched to using generic method syntax.
Good point. Removing this again.

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dart
File lib/src/delegate/future.dart (right):

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dar...
lib/src/delegate/future.dart:31: Future<S> then<S>(dynamic onValue(T value),
{Function onError}) => _future
I just ran dartfmt on all changed files, I didn't actually look at them
afterwards.
Apart from that, I agree completely.

https://codereview.chromium.org/2660333005/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2660333005/diff/1/pubspec.yaml#newcode13
pubspec.yaml:13: sdk: "^1.21.0"
Ah, so there was a reason for it. Going back to old-style.

[nweiz, 2017-02-01 20:41:30]

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dart
File lib/src/delegate/future.dart (right):

https://codereview.chromium.org/2660333005/diff/1/lib/src/delegate/future.dar...
lib/src/delegate/future.dart:31: Future<S> then<S>(dynamic onValue(T value),
{Function onError}) => _future
On 2017/02/01 06:51:37, Lasse Reichstein Nielsen wrote:
> I just ran dartfmt on all changed files, I didn't actually look at them
> afterwards.
> Apart from that, I agree completely.

Unless we're going to adopt a policy of always auto-formatting this package
(which I'd prefer not to since the formatting seems largely worse), I'd like to
revert the unrelated formatting changes.

[Lasse Reichstein Nielsen, 2017-02-02 06:33:03]

I can revert the formatting changes.

I actually think the *unrelated* formatting changes are improvements, it's the
ones that happen on lines that are now slightly shorter, like the "future" you
pointed out, that really suck.

[Lasse Reichstein Nielsen, 2017-02-07 11:58:23]

Formatting changes reverted. PTAL

[nweiz, 2017-02-07 22:28:37]

lgtm

https://codereview.chromium.org/2660333005/diff/30001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2660333005/diff/30001/CHANGELOG.md#newcode5
CHANGELOG.md:5: * Switched to using generic method syntax.
I released 1.13.0 yesterday, so you'll need to make 1.13.1 for this (and maybe
put the pubspec at 1.13.1-dev since it's not a user-visible change and so
doesn't really merit a release).

[Lasse Reichstein Nielsen, 2017-02-15 06:45:31]

Description was changed from

==========
Change generic comment syntax to real generic syntax.
==========

to

==========
Change generic comment syntax to real generic syntax.

R=nweiz@google.com

Committed:
https://github.com/dart-lang/async/commit/7a833401c86e20dd82cfd34e8b9e010425f...
==========

[Lasse Reichstein Nielsen, 2017-02-15 06:45:32]

Committed patchset #4 (id:50001) manually as
7a833401c86e20dd82cfd34e8b9e010425ff8216 (presubmit successful).

[Lasse Reichstein Nielsen, 2017-02-15 06:53:01]

https://codereview.chromium.org/2660333005/diff/30001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2660333005/diff/30001/CHANGELOG.md#newcode5
CHANGELOG.md:5: * Switched to using generic method syntax.
On 2017/02/07 22:28:37, nweiz wrote:
> I released 1.13.0 yesterday, so you'll need to make 1.13.1 for this (and maybe
> put the pubspec at 1.13.1-dev since it's not a user-visible change and so
> doesn't really merit a release).

Done.