Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 26592009: Removing Element.createdCallback (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing Element.createdCallback This was a placeholder for before dart2js converted to the constructor, can now be removed. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=28465

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -70 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +2 lines, -13 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +5 lines, -16 lines 0 comments Download
M tests/html/custom/attribute_changed_callback_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/html/custom/constructor_calls_created_synchronously_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/html/custom/created_callback_test.dart View 3 chunks +7 lines, -11 lines 0 comments Download
M tests/html/custom/entered_left_view_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/html/custom_elements_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-10 00:55:58 UTC) #1
sra1
lgtm
7 years, 2 months ago (2013-10-10 00:58:56 UTC) #2
blois
7 years, 2 months ago (2013-10-10 16:59:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698