Issue 265853011: Display an informative message when we hit the JSON decode bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265853011: Display an informative message when we hit the JSON decode bug. (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 7 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Display an informative message when we hit the JSON decode bug. BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35820

Patch Set 3 : #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5742 lines, -5745 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	476 chunks	+2866 lines, -2852 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	476 chunks	+2847 lines, -2871 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1 2	2 chunks	+29 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm https://codereview.chromium.org/265853011/diff/20001/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/265853011/diff/20001/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode319 runtime/bin/vmservice/client/lib/src/service/object.dart:319: // Two decode failures. remove comment.

6 years, 7 months ago (2014-05-06 18:44:21 UTC) #2

Cutch

6 years, 7 months ago (2014-05-06 19:28:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r35820 (presubmit successful).

Expand Messages | Collapse Messages

Issue 265853011: Display an informative message when we hit the JSON decode bug. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages