Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 265773011: De-duplicate code by adding size-independent iteration. (Closed)

Created:
6 years, 7 months ago by koda
Modified:
6 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

De-duplicate code by adding size-independent iteration. This is also in preparation for potentially having more than two classes of page. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35693

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -71 lines) Patch
M runtime/vm/pages.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 9 chunks +9 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 7 months ago (2014-05-02 00:54:25 UTC) #1
Ivan Posva
LGTM -ip
6 years, 7 months ago (2014-05-02 14:32:45 UTC) #2
koda
6 years, 7 months ago (2014-05-02 16:27:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35693 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698