Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 265773008: fix build java based dart analyzer (Closed)

Created:
6 years, 7 months ago by danrubel
Modified:
6 years, 7 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix build java based dart analyzer BUG=idartbug.com/18289 R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=35665

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M dart.gyp View 2 chunks +9 lines, -1 line 0 comments Download
M editor/analyzer_java.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 7 months ago (2014-05-01 20:35:22 UTC) #1
jwren
On 2014/05/01 20:35:22, danrubel wrote: LGTM
6 years, 7 months ago (2014-05-01 21:41:21 UTC) #2
danrubel
6 years, 7 months ago (2014-05-01 22:12:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698