Issue 265773006: Fix buildbot test breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265773006: Fix buildbot test breakage. (Closed)

Created:
6 years, 7 months ago by turnidge

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix buildbot test breakage. Variable indices are architecture dependent, turns out. BUG= Committed: https://code.google.com/p/dart/source/detail?r=35649

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -46 lines)			Patch
	M	runtime/vm/parser_test.cc	View		10 chunks	+78 lines, -46 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

Committed patchset #1 manually as r35649 (presubmit successful).

6 years, 7 months ago (2014-05-01 18:35:42 UTC) #2

turnidge

6 years, 7 months ago (2014-05-01 18:40:49 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/265773006/diff/1/runtime/vm/parser_test.cc
File runtime/vm/parser_test.cc (right):

https://codereview.chromium.org/265773006/diff/1/runtime/vm/parser_test.cc#ne...
runtime/vm/parser_test.cc:220: (edited_var_str != NULL ? edited_var_str
:var_str));
oops, this works but should be fixed up.  will fix in next cl.  sorry.

Expand Messages | Collapse Messages