Issue 26575004: Rename error to _reportError in HttpParser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26575004: Rename error to _reportError in HttpParser. (Closed)

Created:
7 years, 2 months ago by floitsch

Modified:
7 years, 2 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Rename error to _reportError in HttpParser. The "error" name made it harder for dart2js since it assumed that errors could get called and that the error method would be closurized. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=28508

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	sdk/lib/io/http_parser.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

LGTM, I think the name was legacy from when we had error/addError in one of ...

7 years, 2 months ago (2013-10-11 11:36:37 UTC) #2

floitsch

7 years, 2 months ago (2013-10-11 11:38:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28508 (presubmit successful).