Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 26565006: Rearrange bits in the bitfields to get better compaction, this reduces (Closed)

Created:
7 years, 2 months ago by siva
Modified:
7 years, 2 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Rearrange bits in the bitfields to get better compaction, this reduces initial snapshot size by about 500 bytes. - Fix initialization problem with redirecting factory bit R=rmacnak@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28736

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M runtime/vm/object.h View 1 2 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 2 months ago (2013-10-16 00:40:47 UTC) #1
rmacnak
LGTM
7 years, 2 months ago (2013-10-16 01:06:10 UTC) #2
srdjan
lgtm LGTM!
7 years, 2 months ago (2013-10-16 17:33:31 UTC) #3
siva
7 years, 2 months ago (2013-10-16 17:40:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698