Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 26558008: Adding platform patches to allow custom elements polyfill to work with Shadow DOM. (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding platform patches to allow custom elements polyfill to work with Shadow DOM. The specific issue was that elements existing in the page before the tag was registered was causing issues. This is encountered with the <polymer-element> tag. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=28434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M pkg/custom_element/lib/custom-elements.debug.js View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/custom_element/lib/custom-elements.min.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-09 23:37:30 UTC) #1
Jennifer Messerly
lgtm
7 years, 2 months ago (2013-10-09 23:53:39 UTC) #2
blois
7 years, 2 months ago (2013-10-10 00:30:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698