Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 26557004: Fix for events not firing on sanitized elements (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for events not firing on sanitized elements Issue was that the events weren't being raised when the elements were in documents without views. BUG=14184 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28817

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 2 months ago (2013-10-17 17:52:33 UTC) #1
Emily Fortuna
can you re-upload? I get "chunk mismatch"
7 years, 2 months ago (2013-10-17 18:07:30 UTC) #2
blois
Uploaded.
7 years, 2 months ago (2013-10-17 18:15:17 UTC) #3
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-17 18:27:05 UTC) #4
blois
7 years, 2 months ago (2013-10-17 19:58:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r28817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698