Issue 26546005: Add more specific relation.

Issue 26546005: Add more specific relation. (Closed)

Created:
7 years, 2 months ago by Johnni Winther

Modified:
7 years, 2 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add more specific relation. To be used in type promotion. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=28645

Patch Set 3 : Updated cf. comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -114 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1 2	11 chunks	+126 lines, -46 lines	0 comments	Download
M	tests/compiler/dart2js/subtype_test.dart	View		37 chunks	+83 lines, -68 lines	0 comments	Download
M	tests/compiler/dart2js/type_test_helper.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode1150 sdk/lib/_internal/compiler/implementation/dart_types.dart:1150: bool isSubtype(DartType t, DartType s) { You could ...

7 years, 2 months ago (2013-10-15 11:48:22 UTC) #2

Johnni Winther

Committed patchset #3 manually as r28645 (presubmit successful).

7 years, 2 months ago (2013-10-15 15:14:29 UTC) #3

Johnni Winther

7 years, 2 months ago (2013-10-15 15:15:16 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1150: bool
isSubtype(DartType t, DartType s) {
On 2013/10/15 11:48:22, karlklose wrote:
> You could use isMoreSpecific by extending MoreSpecificVisitor.

Done.

https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1190: s.element ==
compiler.functionClass && lookupCall(t) != null) {
On 2013/10/15 11:48:22, karlklose wrote:
> It feels more consistent to me to break the second line into two.

Done.

https://codereview.chromium.org/26546005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1191: return true;
On 2013/10/15 11:48:22, karlklose wrote:
> Indentation.

Done.

Expand Messages | Collapse Messages