Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 26543002: Use the methods recommended by ARM to flush ICache. (Closed)

Created:
7 years, 2 months ago by zra
Modified:
7 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use the methods recommended by ARM to flush ICache. This allows us to remove selecting different versions of inline assembly depending on ABI, thumb, etc. in our code. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M runtime/vm/cpu_arm.cc View 1 chunk +18 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 2 months ago (2013-10-08 18:15:21 UTC) #1
regis
LGTM
7 years, 2 months ago (2013-10-08 18:27:13 UTC) #2
zra
7 years, 2 months ago (2013-10-08 20:42:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698