Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 26541002: Revert "Fix status files" (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fix status files" This tests all pull in dart:io but do not use them. This CL temporarily made them work: - https://chromiumcodereview.appspot.com/26490003/ This CL restores the previous (and I think correct) behavior: - https://chromiumcodereview.appspot.com/26540002/ BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=28374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M pkg/pkg.status View 3 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
7 years, 2 months ago (2013-10-08 18:09:41 UTC) #1
vsm
7 years, 2 months ago (2013-10-08 18:29:27 UTC) #2
Jacob
lgtm
7 years, 2 months ago (2013-10-08 18:37:25 UTC) #3
vsm
7 years, 2 months ago (2013-10-08 19:25:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698