Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2653753010: Fix URI for packages: make them self contained within the domain served by pub-serve (Closed)

Created:
3 years, 11 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
nweiz, Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1 line) Patch
M lib/src/barback/dart2js_transformer.dart View 2 chunks +9 lines, -1 line 0 comments Download
A test/dart2js/source_maps_are_self_contained_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Siggi Cherem (dart-lang)
3 years, 11 months ago (2017-01-27 00:51:46 UTC) #2
Bob Nystrom
Bouncing to Natalie since I'm out tomorrow.
3 years, 11 months ago (2017-01-27 01:57:41 UTC) #5
nweiz
lgtm
3 years, 11 months ago (2017-01-27 02:04:19 UTC) #6
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-01-27 16:10:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53327f4a7ca2ddd20a40f6a94db61ac136371b03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698