Issue 26520002: Ignore ".DS_Store" and other unexpected files in coverage directory.

Issue 26520002: Ignore ".DS_Store" and other unexpected files in coverage directory. (Closed)

Created:
7 years, 2 months ago by Bob Nystrom

Modified:
7 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore ".DS_Store" and other unexpected files in coverage directory. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28375

Patch Set 2 : Match specific coverage file pattern. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -19 lines)			Patch
	M	tools/full-coverage.dart	View	1	9 chunks	+16 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Currently, this fail on Mac because it tries to read the ".DS_Store" file every directory ...

7 years, 2 months ago (2013-10-08 17:06:50 UTC) #1

Ivan Posva

Thanks for the cleanups. I haven't yet noticed the .DS_Store files as I have not ...

7 years, 2 months ago (2013-10-08 17:50:30 UTC) #2

Bob Nystrom

https://codereview.chromium.org/26520002/diff/1/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/26520002/diff/1/tools/full-coverage.dart#newcode249 tools/full-coverage.dart:249: .where((entity) => entity is File && extension(entity.path) == ".json") ...

7 years, 2 months ago (2013-10-08 18:25:27 UTC) #3

Bob Nystrom

7 years, 2 months ago (2013-10-08 19:31:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28375 (presubmit successful).

Expand Messages | Collapse Messages