Issue 264953004: For nullable/double typed fields compare with null for deoptimization, else assume double.

Issue 264953004: For nullable/double typed fields compare with null for deoptimization, else assume double. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

For nullable/double typed fields compare with null for deoptimization, else assume double. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=35690

Patch Set 4 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -53 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View	1 2	2 chunks	+25 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	2 chunks	+24 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	2 chunks	+24 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	2 chunks	+23 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/264953004/diff/20001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/264953004/diff/20001/runtime/vm/intermediate_language.h#newcode410 runtime/vm/intermediate_language.h:410: intptr_t cid() const { return cid_; } There ...

6 years, 7 months ago (2014-05-02 00:39:24 UTC) #2

srdjan

https://codereview.chromium.org/264953004/diff/20001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/264953004/diff/20001/runtime/vm/intermediate_language.h#newcode410 runtime/vm/intermediate_language.h:410: intptr_t cid() const { return cid_; } On 2014/05/02 ...

6 years, 7 months ago (2014-05-02 15:35:50 UTC) #3

srdjan

6 years, 7 months ago (2014-05-02 15:55:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r35690 (presubmit successful).

Expand Messages | Collapse Messages