Issue 264853006: - implement IsNegative for class Double

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264853006: - implement IsNegative for class Double (Closed)

Created:
6 years, 7 months ago by siva

Modified:
6 years, 7 months ago

Reviewers:
Bill Hesse, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- implement IsNegative for class Double - move IsZero under class Integer as it is not used in class Double R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35648

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	runtime/lib/double.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object.h	View		3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

Committed patchset #1 manually as r35648 (presubmit successful).

6 years, 7 months ago (2014-05-01 18:26:36 UTC) #3

Bill Hesse

The android build needs <math.h> included in object.h now, because signbit is moved from double.cc ...

6 years, 7 months ago (2014-05-02 11:22:10 UTC) #4

Bill Hesse

6 years, 7 months ago (2014-05-02 12:46:12 UTC) #5

Message was sent while issue was closed.

Adding the header file did not work.  I don't know how it was working in the
previous position, in double.cc, but Android is saying that signbit is not
declared, but that
/b/build/slave/dartium/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport/stl/_cmath.h:549:35:
note:   '__captured::signbit' is declared.

Android compile is still broken.

Expand Messages | Collapse Messages