Issue 264743010: Don't remap class/type names in the vm service.

Issue 264743010: Don't remap class/type names in the vm service. (Closed)

Created:
6 years, 7 months ago by turnidge

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't remap class/type names in the vm service. We add a new kind of name, PrettyName, to the vm. This is a name which is demangled but doesn't remap things like _OneByteString to String or _Smi to int. BUG=18360 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35710

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -41 lines)			Patch
M	runtime/vm/disassembler_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5 6	9 chunks	+57 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5 6	20 chunks	+79 lines, -27 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/vmservice/isolate_class_field_test.dart	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with comment. https://codereview.chromium.org/264743010/diff/90001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/264743010/diff/90001/runtime/vm/raw_object.h#newcode483 runtime/vm/raw_object.h:483: RawString* pretty_name_; Is the extra space ...

6 years, 7 months ago (2014-05-02 20:16:21 UTC) #2

turnidge

https://codereview.chromium.org/264743010/diff/90001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/264743010/diff/90001/runtime/vm/raw_object.h#newcode483 runtime/vm/raw_object.h:483: RawString* pretty_name_; On 2014/05/02 20:16:21, Cutch wrote: > Is ...

6 years, 7 months ago (2014-05-02 21:36:36 UTC) #3

turnidge

6 years, 7 months ago (2014-05-02 21:37:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r35710 (presubmit successful).

Expand Messages | Collapse Messages