Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 26443003: pkg/unittest: remove testState (Closed)

Created:
7 years, 2 months ago by kevmoo-old
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : again #

Patch Set 4 : again? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M pkg/unittest/lib/unittest.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
M utils/testrunner/run_pipeline.dart View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
Set only once in all of Dart code base. Never consumed. If the feature is ...
7 years, 1 month ago (2013-10-25 22:09:37 UTC) #1
devoncarew
Hey Kevin, I'm punting my review over to Siggi; my sum-total contribution to unittest has ...
7 years, 1 month ago (2013-10-25 22:32:28 UTC) #2
Siggi Cherem (dart-lang)
lgtm - testrunner is currently unsupported and I'd be surprised if it's running, as long ...
7 years, 1 month ago (2013-10-26 00:37:12 UTC) #3
kevmoo-old
7 years, 1 month ago (2013-10-26 01:33:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r29307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698