Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 26395002: fix polymer copy-instance-attributes feature (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update pkg.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M pkg/pkg.status View 1 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/polymer/test/instance_attrs_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A + pkg/polymer/test/instance_attrs_test.html View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-07 23:55:04 UTC) #1
Jennifer Messerly
oops, I need to tweak pkg.status too for Safari/IE. working on that.
7 years, 2 months ago (2013-10-07 23:55:27 UTC) #2
Jennifer Messerly
added pkg.status changes. BTW, I'm about to send out a fix for Safari and possibly ...
7 years, 2 months ago (2013-10-07 23:57:35 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
7 years, 2 months ago (2013-10-08 00:02:46 UTC) #4
Jennifer Messerly
7 years, 2 months ago (2013-10-08 00:06:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r28339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698