Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2638403002: Make failing HTTP requests thrown when using dart:io. (Closed)

Created:
3 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make failing HTTP requests thrown when using dart:io. Previous behavior was to expose the response content anyway, which was generally empty on a 404 error. R=sgjesse@google.com Committed: https://github.com/dart-lang/resource/commit/39d3a2a66eb4c4fc74e12eb1192e48e678b9e2c2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo in changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/io_io.dart View 5 chunks +16 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/loader_http_test.dart View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-18 14:05:41 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/2638403002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2638403002/diff/1/CHANGELOG.md#newcode4 CHANGELOG.md:4: - Make failing HTTP requests throw and `HttpException`. ...
3 years, 11 months ago (2017-01-18 14:09:22 UTC) #3
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-19 07:59:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
39d3a2a66eb4c4fc74e12eb1192e48e678b9e2c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698