Issue 263803009: Retained size for instance in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263803009: Retained size for instance in Observatory. (Closed)

Created:
6 years, 7 months ago by koda

Modified:
6 years, 7 months ago

Reviewers:
turnidge, Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Retained size for instance in Observatory. Add objects/$id/retained message that uses ObjectGraph to compute retained size for an instance. In the instance view, the user can request the size to be calculated. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35757

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -11 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3 4	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2 3 4	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/instance_view.dart	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/instance_view.html	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object_graph.h	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object_graph.cc	View	1 2 3 4	1 chunk	+60 lines, -0 lines	0 comments	Download
M	runtime/vm/object_graph_test.cc	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2 3 4	2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 2 3 4	3 chunks	+27 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 7 months ago (2014-05-05 19:41:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r35757 (presubmit successful).

Expand Messages | Collapse Messages