Fix an issue where test timeouts would cause no more tests to execute.

Fix an issue where test timeouts would cause no more tests to execute.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28383

[Siggi Cherem (dart-lang), 2013-10-07 21:39:45]

lgtm, with some minor comments below

Peter - I believe you added this functionality, so I'm cc'ing you to make sure
we are understanding this code correctly.

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/src/test_cas...
File pkg/unittest/lib/src/test_case.dart (right):

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/src/test_cas...
pkg/unittest/lib/src/test_case.dart:194: String toString() {
style nit: if it fits on a single line, we could just write:
  String toString() => _result != null ? "$description: $result" : description;

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:753: Timer.run(_nextTestCase);
since this is already in a timer callback, it seems ok to just invoke
_nextTestCase()

(remove the extra Timer.run?)

[devoncarew, 2013-10-07 21:45:33]

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/src/test_cas...
File pkg/unittest/lib/src/test_case.dart (right):

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/src/test_cas...
pkg/unittest/lib/src/test_case.dart:194: String toString() {
On 2013/10/07 21:39:45, Siggi Cherem (dart-lang) wrote:
> style nit: if it fits on a single line, we could just write:
>   String toString() => _result != null ? "$description: $result" :
description;

Done.

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/26359002/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:753: Timer.run(_nextTestCase);
On 2013/10/07 21:39:45, Siggi Cherem (dart-lang) wrote:
> since this is already in a timer callback, it seems ok to just invoke
> _nextTestCase()
> 
> (remove the extra Timer.run?)

Done.

[devoncarew, 2013-10-08 21:57:00]

Committed patchset #2 manually as r28383 (presubmit successful).

[ahe, 2013-10-11 12:59:40]

lgtm

https://codereview.chromium.org/26359002/diff/7001/pkg/unittest/lib/unittest....
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/26359002/diff/7001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:753: _nextTestCase();
This makes sense. Do you need the BREATH_INTERVAL as well?

[devoncarew, 2013-10-11 16:16:46]

https://codereview.chromium.org/26359002/diff/7001/pkg/unittest/lib/unittest....
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/26359002/diff/7001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:753: _nextTestCase();
On 2013/10/11 12:59:41, ahe wrote:
> This makes sense. Do you need the BREATH_INTERVAL as well?

Looks like. A series of test timeouts could prevent DOM events from being
processed for a while. I'll look at creating an _advanceTestCase() method,
calling it from here, and moving that Timer.run()/runAsync() logic from below
into that method.