Issue 26351002: Rename "pub deploy" to "pub build".

Issue 26351002: Rename "pub deploy" to "pub build". (Closed)

Created:
7 years, 2 months ago by Bob Nystrom

Modified:
7 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename "pub deploy" to "pub build". BUG=https://code.google.com/p/dart/issues/detail?id=11363 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=28333

Patch Set 4 : Re-upload. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -497 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	sdk/lib/_internal/pub/lib/src/command/build.dart	View	1 2	5 chunks	+14 lines, -14 lines	0 comments	Download
D	sdk/lib/_internal/pub/lib/src/command/deploy.dart	View		1 chunk	+0 lines, -144 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/compiles_dart_entrypoints_to_dart_and_js_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/copies_browser_js_next_to_entrypoints_test.dart	View	1 2	1 chunk	+11 lines, -11 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/copies_non_dart_files_to_build_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/ignores_non_entrypoint_dart_files_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/reports_dart_parse_errors_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/with_no_web_directory_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
D	sdk/lib/_internal/pub/test/deploy/compiles_dart_entrypoints_to_dart_and_js_test.dart	View		1 chunk	+0 lines, -51 lines	0 comments	Download
	sdk/lib/_internal/pub/test/deploy/copies_browser_js_next_to_entrypoints_test.dart	View	1 2	1 chunk	+0 lines, -98 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/deploy/copies_non_dart_files_to_deploy_test.dart	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files_test.dart	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/deploy/reports_dart_parse_errors_test.dart	View		1 chunk	+0 lines, -50 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/deploy/with_no_web_directory_test.dart	View		1 chunk	+0 lines, -19 lines	0 comments	Download
	sdk/lib/_internal/pub/test/pub_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

I'm getting "old chunk mismatch" errors. Can you re-upload?

7 years, 2 months ago (2013-10-07 21:30:33 UTC) #2

nweiz

lgtm https://codereview.chromium.org/26351002/diff/7001/sdk/lib/_internal/pub/lib/src/command/build.dart File sdk/lib/_internal/pub/lib/src/command/build.dart (right): https://codereview.chromium.org/26351002/diff/7001/sdk/lib/_internal/pub/lib/src/command/build.dart#newcode32 sdk/lib/_internal/pub/lib/src/command/build.dart:32: /// The path to the applications build output ...

7 years, 2 months ago (2013-10-07 21:42:25 UTC) #4

Bob Nystrom

https://codereview.chromium.org/26351002/diff/7001/sdk/lib/_internal/pub/lib/src/command/build.dart File sdk/lib/_internal/pub/lib/src/command/build.dart (right): https://codereview.chromium.org/26351002/diff/7001/sdk/lib/_internal/pub/lib/src/command/build.dart#newcode32 sdk/lib/_internal/pub/lib/src/command/build.dart:32: /// The path to the applications build output directory. ...

7 years, 2 months ago (2013-10-07 22:33:43 UTC) #5

Bob Nystrom

7 years, 2 months ago (2013-10-07 22:48:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r28333 (presubmit successful).

Expand Messages | Collapse Messages