Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 26345002: Last cleanup int -> intptr_t. Also removed a hack. (Closed)

Created:
7 years, 2 months ago by srdjan
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Last cleanup int -> intptr_t. Also removed a hack (boolean is not an integer). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28372

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -42 lines) Patch
M runtime/vm/assembler_arm.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bit_vector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bitmap.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/code_descriptors.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_x64.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/store_buffer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/symbols.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 2 months ago (2013-10-07 21:10:33 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-08 03:48:15 UTC) #2
srdjan
7 years, 2 months ago (2013-10-08 18:54:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28372.

Powered by Google App Engine
This is Rietveld 408576698