Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 263403006: Support deferred libraries in pub build/serve. (Closed)

Created:
6 years, 7 months ago by Bob Nystrom
Modified:
6 years, 7 months ago
Reviewers:
nweiz, kasperl, sigurdm
CC:
reviews_dartlang.org, sethladd, kasperl, sigurdm
Visibility:
Public.

Description

Support deferred libraries in pub build/serve. BUG=https://code.google.com/p/dart/issues/detail?id=16747 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -9 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 1 chunk +11 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A sdk/lib/_internal/pub/test/dart2js/outputs_deferred_libraries_test.dart View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bob Nystrom
This, I think, gets the dart2js transformer in pub supporting deferred libraries. At least, it ...
6 years, 7 months ago (2014-05-06 20:43:14 UTC) #1
nweiz
lgtm
6 years, 7 months ago (2014-05-06 20:53:46 UTC) #2
Bob Nystrom
Committed patchset #1 manually as r35833 (presubmit successful).
6 years, 7 months ago (2014-05-06 21:38:23 UTC) #3
sigurdm
I - on the other hand know very little about pub - but lgtm
6 years, 7 months ago (2014-05-07 10:21:12 UTC) #4
kasperl
When are we going to deprecate the old "syntax" for deferred loading, Sigurd?
6 years, 7 months ago (2014-05-07 10:42:17 UTC) #5
sigurdm
For my sake we can do that right away - I don't know who depends ...
6 years, 7 months ago (2014-05-07 10:59:25 UTC) #6
kasperl
6 years, 7 months ago (2014-05-07 11:01:20 UTC) #7
Message was sent while issue was closed.
Okay, let's see if we can remove the old "syntax" for version 1.5. We can
announce that we're removing it when 1.4 ships.

Powered by Google App Engine
This is Rietveld 408576698