Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 26334002: "Reverting 28321" (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 28321" BUG= Committed: https://code.google.com/p/dart/source/detail?r=28323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -797 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 27 chunks +68 lines, -277 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 15 chunks +47 lines, -163 lines 0 comments Download
M tests/html/keyboard_event_test.dart View 1 chunk +8 lines, -70 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M tools/dom/src/KeyCode.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M tools/dom/src/KeyName.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/KeyboardEventStream.dart View 7 chunks +44 lines, -21 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 2 chunks +4 lines, -114 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 3 chunks +1 line, -26 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
TBR. what passes all the tests on Friday does not necessarily pass all the tests ...
7 years, 2 months ago (2013-10-07 20:10:50 UTC) #1
Emily Fortuna
7 years, 2 months ago (2013-10-07 20:11:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r28323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698